x

ooni · Feb 7, 2024 · a3279f6 · a3279f6
1 parent 3e0e819
commit a3279f6
Show file tree

Hide file tree

Showing 12 changed files with 74 additions and 0 deletions.
diff --git a/internal/experiment/fbmessenger/fbmessenger_test.go b/internal/experiment/fbmessenger/fbmessenger_test.go
@@ -399,6 +399,9 @@ func TestSummaryKeysWithNils(t *testing.T) {
 	if sk.IsAnomaly {
 		t.Fatal("invalid isAnomaly")
 	}
+	if sk.Anomaly() != sk.IsAnomaly {
+		t.Fatal("the values should match")
+	}
 }
 
 func TestSummaryKeysWithFalseFalse(t *testing.T) {
@@ -419,6 +422,9 @@ func TestSummaryKeysWithFalseFalse(t *testing.T) {
 	if sk.IsAnomaly {
 		t.Fatal("invalid isAnomaly")
 	}
+	if sk.Anomaly() != sk.IsAnomaly {
+		t.Fatal("the values should match")
+	}
 }
 
 func TestSummaryKeysWithFalseTrue(t *testing.T) {
@@ -439,6 +445,9 @@ func TestSummaryKeysWithFalseTrue(t *testing.T) {
 	if sk.IsAnomaly == false {
 		t.Fatal("invalid isAnomaly")
 	}
+	if sk.Anomaly() != sk.IsAnomaly {
+		t.Fatal("the values should match")
+	}
 }
 
 func TestSummaryKeysWithTrueFalse(t *testing.T) {
@@ -459,6 +468,9 @@ func TestSummaryKeysWithTrueFalse(t *testing.T) {
 	if sk.IsAnomaly == false {
 		t.Fatal("invalid isAnomaly")
 	}
+	if sk.Anomaly() != sk.IsAnomaly {
+		t.Fatal("the values should match")
+	}
 }
 
 func TestSummaryKeysWithTrueTrue(t *testing.T) {
@@ -479,4 +491,7 @@ func TestSummaryKeysWithTrueTrue(t *testing.T) {
 	if sk.IsAnomaly == false {
 		t.Fatal("invalid isAnomaly")
 	}
+	if sk.Anomaly() != sk.IsAnomaly {
+		t.Fatal("the values should match")
+	}
 }
diff --git a/internal/experiment/hhfm/hhfm_test.go b/internal/experiment/hhfm/hhfm_test.go
@@ -892,6 +892,9 @@ func TestSummaryKeysWorksAsIntended(t *testing.T) {
 			if sk.IsAnomaly != tt.isAnomaly {
 				t.Fatal("unexpected isAnomaly value")
 			}
+			if sk.IsAnomaly != sk.Anomaly() {
+				t.Fatal("unexpected Anomaly() value")
+			}
 		})
 	}
 }
diff --git a/internal/experiment/hirl/hirl_test.go b/internal/experiment/hirl/hirl_test.go
@@ -604,6 +604,9 @@ func TestSummaryKeysFalse(t *testing.T) {
 	if sk.IsAnomaly {
 		t.Fatal("invalid isAnomaly")
 	}
+	if sk.Anomaly() != sk.IsAnomaly {
+		t.Fatal("invalid Anomaly()")
+	}
 }
 
 func TestSummaryKeysTrue(t *testing.T) {
@@ -615,4 +618,7 @@ func TestSummaryKeysTrue(t *testing.T) {
 	if sk.IsAnomaly == false {
 		t.Fatal("invalid isAnomaly")
 	}
+	if sk.Anomaly() != sk.IsAnomaly {
+		t.Fatal("invalid Anomaly()")
+	}
 }
diff --git a/internal/experiment/ndt7/ndt7_test.go b/internal/experiment/ndt7/ndt7_test.go
@@ -260,4 +260,7 @@ func TestSummaryKeysGood(t *testing.T) {
 	if sk.IsAnomaly {
 		t.Fatal("invalid isAnomaly")
 	}
+	if sk.IsAnomaly != sk.Anomaly() {
+		t.Fatal("invalid Anomaly()")
+	}
 }
diff --git a/internal/experiment/psiphon/psiphon_test.go b/internal/experiment/psiphon/psiphon_test.go
@@ -149,4 +149,7 @@ func TestSummaryKeysFailure(t *testing.T) {
 	if sk.IsAnomaly == false {
 		t.Fatal("invalid isAnomaly")
 	}
+	if sk.IsAnomaly != sk.Anomaly() {
+		t.Fatal("invalid Anomaly()")
+	}
 }
diff --git a/internal/experiment/signal/signal_test.go b/internal/experiment/signal/signal_test.go
@@ -113,3 +113,23 @@ func TestBadSignalCA(t *testing.T) {
 		t.Fatal("not the error we expected")
 	}
 }
+
+func TestSummaryKeys(t *testing.T) {
+	t.Run("without anomaly", func(t *testing.T) {
+		sk := &signal.SummaryKeys{
+			IsAnomaly: false,
+		}
+		if sk.IsAnomaly != sk.Anomaly() {
+			t.Fatal("invalid Anomaly()")
+		}
+	})
+
+	t.Run("with anomaly", func(t *testing.T) {
+		sk := &signal.SummaryKeys{
+			IsAnomaly: false,
+		}
+		if sk.IsAnomaly != sk.Anomaly() {
+			t.Fatal("invalid Anomaly()")
+		}
+	})
+}
diff --git a/internal/experiment/telegram/telegram_test.go b/internal/experiment/telegram/telegram_test.go
@@ -245,6 +245,9 @@ func TestSummaryKeysWorksAsIntended(t *testing.T) {
 			if sk.IsAnomaly != tt.isAnomaly {
 				t.Fatal("unexpected isAnomaly value")
 			}
+			if sk.IsAnomaly != sk.Anomaly() {
+				t.Fatal("invalid Anomaly()")
+			}
 		})
 	}
 }

diff --git a/internal/experiment/tor/tor_test.go b/internal/experiment/tor/tor_test.go
@@ -769,6 +769,9 @@ func TestSummaryKeysWorksAsIntended(t *testing.T) {
 			if sk.IsAnomaly != tt.isAnomaly {
 				t.Fatal("unexpected isAnomaly value")
 			}
+			if sk.IsAnomaly != sk.Anomaly() {
+				t.Fatal("invalid Anomaly()")
+			}
 		})
 	}
 }

diff --git a/internal/experiment/torsf/torsf_test.go b/internal/experiment/torsf/torsf_test.go
@@ -423,6 +423,9 @@ func TestMeasurementSummaryKeys(t *testing.T) {
 		if rsk.IsAnomaly {
 			t.Fatal("expected no anomaly here")
 		}
+		if rsk.IsAnomaly != sk.Anomaly() {
+			t.Fatal("invalid Anomaly()")
+		}
 	})
 
 	t.Run("in case of failure", func(t *testing.T) {
@@ -437,5 +440,8 @@ func TestMeasurementSummaryKeys(t *testing.T) {
 		if !rsk.IsAnomaly {
 			t.Fatal("expected anomaly here")
 		}
+		if rsk.IsAnomaly != sk.Anomaly() {
+			t.Fatal("invalid Anomaly()")
+		}
 	})
 }
diff --git a/internal/experiment/vanillator/vanillator_test.go b/internal/experiment/vanillator/vanillator_test.go
@@ -306,6 +306,9 @@ func TestMeasurementSummaryKeys(t *testing.T) {
 		if rsk.IsAnomaly {
 			t.Fatal("expected no anomaly here")
 		}
+		if rsk.IsAnomaly != sk.Anomaly() {
+			t.Fatal("invalid Anomaly()")
+		}
 	})
 
 	t.Run("in case of failure", func(t *testing.T) {
@@ -320,5 +323,8 @@ func TestMeasurementSummaryKeys(t *testing.T) {
 		if !rsk.IsAnomaly {
 			t.Fatal("expected anomaly here")
 		}
+		if rsk.IsAnomaly != sk.Anomaly() {
+			t.Fatal("invalid Anomaly()")
+		}
 	})
 }
diff --git a/internal/experiment/webconnectivity/webconnectivity_test.go b/internal/experiment/webconnectivity/webconnectivity_test.go
@@ -419,6 +419,9 @@ func TestSummaryKeysWorksAsIntended(t *testing.T) {
 			if sk.Blocking != tt.Blocking {
 				t.Fatal("unexpected Accessible value")
 			}
+			if sk.IsAnomaly != sk.Anomaly() {
+				t.Fatal("invalid Anomaly()")
+			}
 		})
 	}
 }
diff --git a/internal/experiment/whatsapp/whatsapp_test.go b/internal/experiment/whatsapp/whatsapp_test.go
@@ -609,6 +609,9 @@ func TestSummaryKeysWorksAsIntended(t *testing.T) {
 			if sk.EndpointsBlocking != tt.EndpointsBlocking {
 				t.Fatal("unexpected endpointsBlocking value")
 			}
+			if sk.IsAnomaly != sk.Anomaly() {
+				t.Fatal("invalid Anomaly()")
+			}
 		})
 	}
 }