-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: rename sessionresolver engineresolver (#1264)
I am soon going to start addressing the underlying issue described by ooni/probe#2531. But, before doing that, I have noticed that the packages I need to edit to this end are the following: ``` ./internal/engine ./internal/geolocate ./internal/sessionresolver ``` Now, these three packages work in unison to provide an `engine.Session` and they should *sort* together. However, I would like also to avoid nesting because I think each of them serves an ~independent purpose, and geolocate and sessionresolver are possibly building blocks to refactor or reimplement the engine. For this reason, I have chosen to rename them such that it is clear they are the engine and supporting packages. This diff addresses the second half of the change by renaming the sessionresolver package.
1 parent
8c0646a
commit 761e79e
Showing
17 changed files
with
27 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/errwrapper.go → internal/engineresolver/errwrapper.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
// | ||
// Error wrapping | ||
|
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/errwrapper_test.go → internal/engineresolver/errwrapper_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
import ( | ||
"errors" | ||
|
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/factory.go → internal/engineresolver/factory.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
import ( | ||
"errors" | ||
|
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/factory_test.go → internal/engineresolver/factory_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
import ( | ||
"context" | ||
|
6 changes: 3 additions & 3 deletions
6
internal/sessionresolver/integration_test.go → internal/engineresolver/integration_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/jsoncodec.go → internal/engineresolver/jsoncodec.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
// | ||
// JSON codec | ||
|
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/jsoncodec_test.go → internal/engineresolver/jsoncodec_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
import ( | ||
"testing" | ||
|
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/lookup.go → internal/engineresolver/lookup.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
// | ||
// Actual lookup code | ||
|
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/lookup_test.go → internal/engineresolver/lookup_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
import ( | ||
"context" | ||
|
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/resolver.go → internal/engineresolver/resolver.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
// | ||
// Implementation of model.Resolver | ||
|
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/resolver_test.go → internal/engineresolver/resolver_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
import ( | ||
"context" | ||
|
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/resolvermaker.go → internal/engineresolver/resolvermaker.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
// | ||
// High-level code for creating a new child resolver | ||
|
2 changes: 1 addition & 1 deletion
2
...nal/sessionresolver/resolvermaker_test.go → ...rnal/engineresolver/resolvermaker_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
import ( | ||
"strings" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
internal/sessionresolver/state_test.go → internal/engineresolver/state_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package sessionresolver | ||
package engineresolver | ||
|
||
import ( | ||
"errors" | ||
|