-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cleanup: remove jafar and the previous QA framework (#1244)
## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#1803 - [x] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: N/A - [x] if you changed code inside an experiment, make sure you bump its version number: N/A ## Description This is the final act of the quest to replace Jafar. Let's remove Jafar itself and the QA framework using it. We now have a much better QA framework, that runs for each commit, is faster, and allows to better emulate censorship cases. While working on the removal, I noticed some tutorials depended on a limited set of Jafar functionality, namely the possibility of provoking simple censorship conditions. So, I refactored the previous code for managing iptables on Linux used by Jafar to produce a much slimmer, fully unit tested tool implementing a subset of the original CLI. By implementing this change, we make sure that we still have simple ways for people to learn while reading tutorials. What remains to be done at this point is to update existing issues, close done issues, and generally make sure we explain clearly what we achieved by working on this quest, and what new features are now available.
- Loading branch information
1 parent
18f9dcb
commit 2051a2d
Showing
51 changed files
with
601 additions
and
3,102 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.