Skip to content

refactor(all): improve SummaryKeys management #4760

refactor(all): improve SummaryKeys management

refactor(all): improve SummaryKeys management #4760

Triggered via pull request February 6, 2024 17:08
Status Failure
Total duration 2m 55s
Artifacts

coverage.yml

on: pull_request
measure_coverage
2m 43s
measure_coverage
finish_measuring_coverage
0s
finish_measuring_coverage
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
measure_coverage: internal/mocks/database.go#L29
cannot use &Database{} (value of type *Database) as model.WritableDatabase value in variable declaration: *Database does not implement model.WritableDatabase (wrong type for method AddTestKeys)
measure_coverage: internal/engine/experiment_integration_test.go#L288
assignment mismatch: 2 variables but experiment.GetSummaryKeys returns 1 value
measure_coverage: internal/experiment/dnscheck/dnscheck_test.go#L112
measurer.GetSummaryKeys undefined (type model.ExperimentMeasurer has no field or method GetSummaryKeys)
measure_coverage: internal/experiment/dnscheck/dnscheck_test.go#L185
m.GetSummaryKeys undefined (type *Measurer has no field or method GetSummaryKeys)
measure_coverage: internal/experiment/example/example_test.go#L38
m.GetSummaryKeys undefined (type model.ExperimentMeasurer has no field or method GetSummaryKeys)
measure_coverage: internal/experiment/example/example_test.go#L69
m.GetSummaryKeys undefined (type *example.Measurer has no field or method GetSummaryKeys)
measure_coverage: internal/experiment/httphostheader/httphostheader_test.go#L56
measurer.GetSummaryKeys undefined (type model.ExperimentMeasurer has no field or method GetSummaryKeys)
measure_coverage: internal/experiment/httphostheader/httphostheader_test.go#L99
m.GetSummaryKeys undefined (type *Measurer has no field or method GetSummaryKeys)
measure_coverage: internal/experiment/hhfm/hhfm_test.go#L261
measurer.GetSummaryKeys undefined (type model.ExperimentMeasurer has no field or method GetSummaryKeys)
measure_coverage: internal/experiment/hhfm/hhfm_test.go#L869
m.GetSummaryKeys undefined (type *hhfm.Measurer has no field or method GetSummaryKeys)
measure_coverage
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.