fix: Improve how in progress tests are displayed #673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellais
reviewed
Feb 21, 2024
| if (cursor.moveToFirst()) { | ||
| cursor.getColumnIndex("in_progress_count").let { | ||
| if (it == -1) { | ||
| return@let |
There was a problem hiding this comment.
Exit the let call and not the function
hellais
reviewed
Feb 21, 2024
| @@ -151,6 +151,10 @@ private void runTest(AbstractTest... tests) { | |||
| currentTest.run(app, app.getPreferenceManager(),app.getLogger(), app.getGson(), result, i, this); | |||
| } | |||
| } | |||
| if (result.countTotalMeasurements() == tests.length) { | |||
There was a problem hiding this comment.
Where is this function defined?
Maybe this function should be called "countTotalCompletedMeasurements" or something of that sort.
Also, what exactly is counted here? Is it really a measurements or is it a nettest in a group?
For example if you run web_connectivity against 10 URLs and then whatsaapp, would this count be 11 or would it be 2?
There was a problem hiding this comment.
- The
nettestpaired with the input it is run with to create the measurement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ooni/probe#2658
Proposed Changes