Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tailwind for styling components #175

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Use Tailwind for styling components #175

merged 7 commits into from
Aug 7, 2024

Conversation

majakomel
Copy link
Contributor

@majakomel majakomel commented Apr 23, 2024

Closes #174

Components that were removed as they were redundant:

  • Box
  • Button
  • Container
  • Flex
  • Heading
  • Hero
  • HeroLead
  • Image
  • InputWithIconButton
  • Link
  • Text
  • TwitterShareButton
  • FacebookShareButton

Instead of React components, heading and button styles are defined in tailwind.css, that should be imported in the project that's using ooni-components

The old rebass theme was translated to tailwind format: https://github.com/ooni/design-system/pull/175/files#diff-57b2e05901183e501b094c0102651a7631f1262a0dc1b84d61db844ec0423031, same for colors: https://github.com/ooni/design-system/pull/175/files#diff-a274c7da6745d160eea40d93ebc2355288194baea2f19e3f30ceb057f4f9e31f

@majakomel majakomel self-assigned this Apr 23, 2024
Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 11:25am

Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave a scroll at it and it looks good to me.

Thanks for working on this and so glad to see it come together! 🥳

@majakomel majakomel merged commit 847c6d7 into master Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement components using TailwindCSS (and remove the use of styled-components + styled-system)
2 participants