Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5.0.0 alpha-4 #83

Merged
merged 26 commits into from
Sep 9, 2024
Merged

V5.0.0 alpha-4 #83

merged 26 commits into from
Sep 9, 2024

Conversation

hellais
Copy link
Member

@hellais hellais commented Aug 23, 2024

As part of this alpha release the following is implemented:

  • Add a web interface for viewing observations
  • Add an API for returning aggregates of observations
  • Add a web view for plotting aggregates of observations
  • Refactoring of observation related activities:
  • Add support for performing observation generation using multiple
    cores, instead of multiple threads since it's CPU bound
    • Separate observation activities into distinct smaller activities
      allowing for more narrowly scoped scheduling and retry policies
    • Change the type of PrevRange so that it's possible to serialize it in
      JSON allowing to pass it as a parameter to activities
    • Move update_assets into observation activity
    • Add support for passing config file via CONFIG_FILE environment
      variable
    • Improvements to the CLI commands
    • Drop several CLI arguments that should only be read from the config
      file
    • Other improvements related to typing

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 85.88235% with 72 lines in your changes missing coverage. Please review.

Project coverage is 81.56%. Comparing base (2d54c38) to head (e3da154).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ine/src/oonipipeline/temporal/client_operations.py 28.57% 15 Missing ⚠️
...c/oonipipeline/temporal/activities/observations.py 88.23% 12 Missing ⚠️
...onipipeline/src/oonipipeline/temporal/schedules.py 84.41% 12 Missing ⚠️
oonipipeline/src/oonipipeline/cli/commands.py 57.14% 9 Missing ⚠️
oonipipeline/src/oonipipeline/temporal/workers.py 50.00% 7 Missing ⚠️
...peline/src/oonipipeline/temporal/workflows/ctrl.py 78.26% 5 Missing ⚠️
...ine/src/oonipipeline/temporal/activities/common.py 78.94% 4 Missing ⚠️
...line/src/oonipipeline/temporal/workflows/common.py 72.72% 3 Missing ⚠️
.../oonipipeline/temporal/activities/ground_truths.py 66.66% 1 Missing ⚠️
oonipipeline/src/oonipipeline/temporal/common.py 95.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   77.41%   81.56%   +4.14%     
==========================================
  Files          32       82      +50     
  Lines        1913     6351    +4438     
==========================================
+ Hits         1481     5180    +3699     
- Misses        432     1171     +739     
Flag Coverage Δ
oonidata 77.44% <100.00%> (+0.02%) ⬆️
oonipipeline 83.34% <85.79%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This implements: #35

This branch is based on top of #44. That one should be merged before
this one is ready to be landed in master.
* Add support for performing observation generation using multiple
cores, instead of multiple threads since it's CPU bound
* Separate observation activities into distinct smaller activities
allowing for more narrowly scoped scheduling and retry policies
* Change the type of PrevRange so that it's possible to serialize it in
JSON allowing to pass it as a parameter to activities
* Move update_assets into observation activity
* Add support for passing config file via `CONFIG_FILE` environment
variable
* Improvements to the CLI commands
* Drop several CLI arguments that should only be read from the config
file
* Other improvements related to typing
Add comments to wait for mutation calls
Add exception handling in observation generation
Make the scheduling operation throw errors if a schedule already exists
@hellais hellais changed the title V5.0.0 rc.0 V5.0.0 alpha-3 Sep 9, 2024
@hellais hellais merged commit ff1fc86 into main Sep 9, 2024
9 checks passed
@hellais hellais deleted the v5.0.0-rc.0 branch September 9, 2024 14:50
@hellais hellais changed the title V5.0.0 alpha-3 V5.0.0 alpha-4 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant