Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colloscope #35

Merged
merged 13 commits into from
Dec 22, 2023
Merged

Colloscope #35

merged 13 commits into from
Dec 22, 2023

Conversation

FlashOnFire
Copy link
Collaborator

@FlashOnFire FlashOnFire commented Dec 21, 2023

Introducing Colloscope integration for polytech students!

This is the v1 of the polytech colloscope

Currently not working if you don't go to the tomuss tab before colloscope tab as it relies on tomuss data to get the student name.
Also missing a proper icon.

We will also need to publish the polytechcolloscopeclient lib to be able to build without melos

i will probably redesign the page in the future but i think it's fine as a first implementation

@FlashOnFire FlashOnFire marked this pull request as ready for review December 21, 2023 20:46
@FlashOnFire FlashOnFire changed the title Draft: Colloscope Colloscope Dec 21, 2023
@hatch01
Copy link
Member

hatch01 commented Dec 22, 2023

No notifications ?

@FlashOnFire
Copy link
Collaborator Author

No notifications ?

Not yet

Copy link
Member

@hatch01 hatch01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems realy clean !


# Add regular dependencies here.
dependencies:
beautiful_soup_dart: ^0.3.0
collection: ^1.18.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Euuu

@hatch01
Copy link
Member

hatch01 commented Dec 22, 2023

/fast-forward

@hatch01 hatch01 merged commit 8481b55 into onyx-lyon1:dev Dec 22, 2023
0 of 5 checks passed
@FlashOnFire FlashOnFire self-assigned this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants