Refactor: update cache code and add tests #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphax-bouazzouni
added a commit
that referenced
this pull request
May 27, 2024
* use $DEBUG_API_CLIENT instead of $DEBUG for debugging request * add $API_CLIENT_INVALIDATE_CACHE option to disable cache * save and re-use the top_level_links http response as the result do not change * deprecate the find method in favor of get method for better performance * disable the refresh_cache on each update call * Refactor: update cache code and add tests (#15) * add tests for the api cache code * refactor the cache middleware code * remove unused function in the cache middleware * fix refactored cache code not getting the ld_obj when updating the cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes