Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Add alias resolve for resolve_field method #95

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

durcak
Copy link

@durcak durcak commented Sep 11, 2019

Compatibility for new GraphQL::Execution::Interpreter, because the interpreter calls a different method: #resolve(obj, args, ctx), instead of #resolve_field(obj, args, ctx).

@durcak
Copy link
Author

durcak commented Sep 11, 2019

This need more changes, than I thought 👎

@durcak durcak closed this Sep 11, 2019
@durcak durcak reopened this Sep 11, 2019
@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         785    794    +9     
=====================================
+ Hits          785    794    +9
Impacted Files Coverage Δ
lib/graphql-pundit/scope.rb 100% <100%> (ø) ⬆️
spec/graphql-pundit/authorization_spec.rb 100% <100%> (ø) ⬆️
spec/graphql-pundit/scope_spec.rb 100% <100%> (ø) ⬆️
lib/graphql-pundit/authorization.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5961fb...dead7be. Read the comment docs.

@durcak
Copy link
Author

durcak commented Sep 12, 2019

Test are probably failing because of bug refered in issue 53

@durcak
Copy link
Author

durcak commented Jan 22, 2020

@phyrog Hi can you look at this? There is new release of graphql gem 1.10.0 with new interpreter as default. Thanks.

Copy link
Contributor

@stickler-ci stickler-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your rubocop configuration output the following error:

.rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout

Copy link
Contributor

@stickler-ci stickler-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your rubocop configuration output the following error:

.rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants