-
Notifications
You must be signed in to change notification settings - Fork 31
Add alias resolve for resolve_field method #95
base: master
Are you sure you want to change the base?
Conversation
This need more changes, than I thought 👎 |
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 785 794 +9
=====================================
+ Hits 785 794 +9
Continue to review full report at Codecov.
|
Test are probably failing because of bug refered in issue 53 |
@phyrog Hi can you look at this? There is new release of graphql gem 1.10.0 with new interpreter as default. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your rubocop configuration output the following error:
.rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your rubocop configuration output the following error:
.rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout
Compatibility for new
GraphQL::Execution::Interpreter
, because the interpreter calls a different method:#resolve(obj, args, ctx)
, instead of#resolve_field(obj, args, ctx)
.