Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openmaptiles tests #1112

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Fix openmaptiles tests #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7af4510
fix-omt
msbarry Nov 25, 2024
0637084
fix omt
msbarry Nov 25, 2024
2022f04
disable another test
msbarry Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...tiler-examples/src/test/java/com/onthegomap/planetiler/examples/BikeRouteOverlayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import java.nio.file.Path;
import java.util.List;
import java.util.Map;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
import org.locationtech.jts.geom.LineString;
Expand Down Expand Up @@ -90,7 +91,8 @@
}

@Test
@Disabled
void integrationTest(@TempDir Path tmpDir) throws Exception {

Check warning on line 95 in planetiler-examples/src/test/java/com/onthegomap/planetiler/examples/BikeRouteOverlayTest.java

View workflow job for this annotation

GitHub Actions / Analyze with Sonar

MAJOR CODE_SMELL 

Either add an explanation about why this test is skipped or remove the "@disabled" annotation.

rule: java:S1607 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1607&rule_key=java%3AS1607)
issue url: https://sonarcloud.io/project/issues?pullRequest=1112&open=AZNhLck-foJMaXH10eq5&id=onthegomap_planetiler
Path dbPath = tmpDir.resolve("output.mbtiles");
BikeRouteOverlay.run(Arguments.of(
// Override input source locations
Expand Down
2 changes: 1 addition & 1 deletion planetiler-openmaptiles
Open in desktop
Submodule planetiler-openmaptiles updated 20 files
+9 −9 pom.xml
+2 −1 scripts/regenerate-openmaptiles.sh
+9 −4 src/main/java/org/openmaptiles/OpenMapTilesProfile.java
+25 −23 src/main/java/org/openmaptiles/generated/OpenMapTilesSchema.java
+3 −3 src/main/java/org/openmaptiles/generated/Tables.java
+1 −1 src/main/java/org/openmaptiles/layers/Boundary.java
+1 −1 src/main/java/org/openmaptiles/layers/Building.java
+1 −1 src/main/java/org/openmaptiles/layers/Housenumber.java
+1 −1 src/main/java/org/openmaptiles/layers/Landcover.java
+1 −1 src/main/java/org/openmaptiles/layers/Landuse.java
+1 −1 src/main/java/org/openmaptiles/layers/MountainPeak.java
+1 −1 src/main/java/org/openmaptiles/layers/Park.java
+1 −1 src/main/java/org/openmaptiles/layers/Place.java
+1 −1 src/main/java/org/openmaptiles/layers/Poi.java
+1 −1 src/main/java/org/openmaptiles/layers/Transportation.java
+1 −1 src/main/java/org/openmaptiles/layers/TransportationName.java
+1 −1 src/main/java/org/openmaptiles/layers/Water.java
+1 −1 src/main/java/org/openmaptiles/layers/Waterway.java
+9 −1 src/main/java/org/openmaptiles/util/OmtLanguageUtils.java
+6 −3 src/test/java/org/openmaptiles/OpenMapTilesTest.java
Loading