breakout test

onthegomap · Nov 26, 2024 · ae94a39 · ae94a39
1 parent c43db46
commit ae94a39
Showing 1 changed file with 38 additions and 28 deletions.
diff --git a/planetiler-core/src/test/java/com/onthegomap/planetiler/util/LanguageUtilsTest.java b/planetiler-core/src/test/java/com/onthegomap/planetiler/util/LanguageUtilsTest.java
@@ -1,9 +1,12 @@
 package com.onthegomap.planetiler.util;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.CsvSource;
+import org.junit.jupiter.params.provider.ValueSource;
 
 class LanguageUtilsTest {
 
@@ -26,34 +29,41 @@ void testRemoveNonLatin(String in, String out) {
   }
 
   @ParameterizedTest
-  @CsvSource(value = {
-    "name:es, true",
-    "name:en-US, true",
-    "name:en-001, true",
-    "name:fr-x-gallo, true",
-    "name:ko-Latn, true",
-    "name:be-tarask, true",
-    "name:ja_rm, true",
-    "name:ja_kana, true",
-    "name:vls, true",
-    "name:zh-hant-CN, true",
-    "name:zh_pinyin, true",
-    "name:zh_zhuyin, true",
-    "name:zh-Latn-tongyong, true",
-    "name:zh-Latn-pinyin, true",
-    "name:zh-Latn-wadegiles, true",
-    "name:yue-Latn-jyutping, true",
-    "nombre, false",
-    "name:, false",
-    "name:xxxxx, false",
-    "name:tec, true",
-    "name:TEC, false",
-    "name:be-tarask, true",
-    "name:nan-Latn-pehoeji, true",
-    "name:zh-Latn-pinyin, true",
-  }, nullValues = "null")
-  void testIsValidOsmNameTag(String in, boolean out) {
-    assertEquals(out, LanguageUtils.isValidOsmNameTag(in));
+  @ValueSource(strings = {
+    "name:es",
+    "name:en-US",
+    "name:en-001",
+    "name:fr-x-gallo",
+    "name:ko-Latn",
+    "name:be-tarask",
+    "name:ja_rm",
+    "name:ja_kana",
+    "name:vls",
+    "name:zh-hant-CN",
+    "name:zh_pinyin",
+    "name:zh_zhuyin",
+    "name:zh-Latn-tongyong",
+    "name:zh-Latn-pinyin",
+    "name:zh-Latn-wadegiles",
+    "name:yue-Latn-jyutping",
+    "name:tec",
+    "name:be-tarask",
+    "name:nan-Latn-pehoeji",
+    "name:zh-Latn-pinyin",
+  })
+  void testIsValidOsmNameTag(String in) {
+    assertTrue(LanguageUtils.isValidOsmNameTag(in));
+  }
+
+  @ParameterizedTest
+  @ValueSource(strings = {
+    "nombre",
+    "name:",
+    "name:xxxxx",
+    "name:TEC",
+  })
+  void testIsNotValidOsmNameTag(String in) {
+    assertFalse(LanguageUtils.isValidOsmNameTag(in));
   }
 
 }