Fix geoarrow sonar (#934)

onthegomap · Jun 27, 2024 · 73a8144 · 73a8144
1 parent cf534c1
commit 73a8144
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/...r-core/src/main/java/com/onthegomap/planetiler/reader/parquet/ParquetRecordConverter.java b/...r-core/src/main/java/com/onthegomap/planetiler/reader/parquet/ParquetRecordConverter.java
@@ -168,14 +168,18 @@ protected Converter makeConverter(Context child) {
       return new StructConverter(child) {
 
         @Override
-        public void start() {}
+        public void start() {
+          // don't start a new struct
+        }
 
         @Override
         protected Converter makeConverter(Context child) {
           return new StructConverter(child) {
 
             @Override
-            public void start() {}
+            public void start() {
+              // don't start a new struct
+            }
 
             @Override
             public void end() {
@@ -235,12 +239,6 @@ public void addDouble(double value) {
 
     @Override
     protected Converter makeConverter(Context child) {
-      class CoordinateSetter extends PrimitiveConverter {
-        @Override
-        public void addDouble(double value) {
-          super.addDouble(value);
-        }
-      }
       return switch (child.type.getName()) {
         case "x" -> ordinateSetter(0);
         case "y" -> ordinateSetter(1);
@@ -593,12 +591,12 @@ public boolean isGeoArrowCoordSeq() {
         repeatedElement.asGroupType().getFieldCount() != 1) {
         return false;
       }
-      return isGeoarrowCoordinate(repeatedElement.asGroupType().getType(0));
+      return isGeoArrowCoordinate(repeatedElement.asGroupType().getType(0));
     }
 
     public boolean isGeoArrowCoordinate() {
       String geoArrowType = getGeoArrowType();
-      return geoArrowType != null && geoArrowType.contains("point") && isGeoarrowCoordinate(type);
+      return geoArrowType != null && geoArrowType.contains("point") && isGeoArrowCoordinate(type);
     }
 
     private String getGeoArrowType() {
@@ -612,7 +610,7 @@ private String getGeoArrowType() {
       }
     }
 
-    private static boolean isGeoarrowCoordinate(Type struct) {
+    private static boolean isGeoArrowCoordinate(Type struct) {
       if (struct.isPrimitive()) {
         return false;
       }