New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null 'format' in DateRangeAggregation #351

Open

pmishev wants to merge 1 commit into ongr-io:7.1 from pmishev:7.1-daterangeaggregation-fix

Contributor

pmishev commented Mar 11, 2021

Allow null 'format' in DateRangeAggregation

Without this, calling:

        $ranges[] = ['from' => time()-1000, 'to' => time(), 'key' => 'time_range'];
        $rangeAgg = new DateRangeAggregation('myagg', 'created', null, $ranges, true);

results in an exception, but it shouldn't as format is optional.


          Allow null 'format' in DateRangeAggregation, as it is not required

5d9771c

pmishev changed the title ~~Fluent api on ParametersTrait (#304)~~ Allow null 'format' in DateRangeAggregation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet