implemented requirements of the PHP 8 #348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylich
reviewed
Jan 28, 2021
| public function __construct($name, $field = null, $origin = null, $ranges = [], $unit = null, $distanceType = null) | ||
| { | ||
| public function __construct( | ||
| protected string $name, |
There was a problem hiding this comment.
Why did you change properties to protected?
| $extendedBoundsMin = null, | ||
| $extendedBoundsMax = null, | ||
| $keyed = null | ||
| private string $name, |
There was a problem hiding this comment.
Why you changed visibility to private?
There was a problem hiding this comment.
Otherwise, there will be a mixture of properties and method parameters
| * @throws \LogicException | ||
| */ | ||
| private function isRequiredParametersSet($a) | ||
| private function isRequiredParametersSet(array $a): void |
There was a problem hiding this comment.
The previous implementation returned bool, why did you changed to void?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented requirements of the PHP 8