Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain environment variable when loading key from config #78

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Dec 9, 2024

closes #79

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.00%. Comparing base (61b6da5) to head (a1b6bb2).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
accounts/keys.go 77.77% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   43.82%   44.00%   +0.18%     
==========================================
  Files          40       40              
  Lines        3366     3384      +18     
==========================================
+ Hits         1475     1489      +14     
- Misses       1631     1634       +3     
- Partials      260      261       +1     
Flag Coverage Δ
unittests 44.00% <77.77%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink merged commit ec899a0 into main Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] When loading env key from config, environment variable is not retained
3 participants