fix issue with overridden default options #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthpun
requested review from
Kay-Zee,
janezpodhostnik,
sideninja,
chasefleming,
nvdtf,
bluesign,
bjartek and
jribbink
as code owners
bjartek
approved these changes
May 7, 2024
turbolent
reviewed
May 7, 2024
|
@turbolent Im trying to see if its possible, but i think we're going to have the same issue as I've outlined here We can confirm that the length is the same, but due to how function signatures are compared, I haven't been able to figure out how to compare functions being called here. I think the most ideal solution would be to see all dialOptions set and just compare the output there. Let me think about this for a little bit |
turbolent
approved these changes
May 7, 2024
|
Really culdnt find a way to test this unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the options call so that it adds the default first, then adds the options after so the default doesnt override the incoming options (prepend vs append)