Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend code submission for FLIP fest 'Playground Feature: Markdown READMEs 18' #173

Closed
wants to merge 8 commits into from

Conversation

hichana
Copy link
Contributor

@hichana hichana commented Oct 26, 2021

Closes: N/A

Description

This PR comprises the work by @J00LZ and @hichana on the FLIP fest 'Playground Feature: Markdown READMEs 18'. It adds a 'PROJECT' section that allows the user to create a title, description and readme for the project, with functionality integrated into the export feature (ex. the readme.md file exports with the rest of the code) and various redirects schemes to enhance the user experience.

We made a comprehensive guide with screenshots to illustrate the features: https://github.com/hichana/flip-fest/blob/submissions/issue-%2318/milestone-%232/TeamExponential/submission/issue-18/milestone-2/TeamExponential/README.md


For contributor use:

  • [x ] Targeted PR against correct branch (see CONTRIBUTING.md)
  • [x ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • x[ ] Code follows the standards mentioned here.
  • [n/a ] Updated relevant documentation
  • [x ] Re-reviewed Files changed in the Github PR explorer
  • [n/a ] Added appropriate labels

@hichana hichana requested a review from 10thfloor as a code owner October 26, 2021 07:24
@vercel
Copy link

vercel bot commented Oct 26, 2021

@hichana is attempting to deploy a commit to the Flow Team on Vercel.

A member of the Team first needs to authorize it.

@hichana hichana changed the title Code submission for FLIP fest 'Playground Feature: Markdown READMEs 18 - Milestone 2' Code submission for FLIP fest 'Playground Feature: Markdown READMEs 18' Oct 26, 2021
@hichana hichana changed the title Code submission for FLIP fest 'Playground Feature: Markdown READMEs 18' Frontend code submission for FLIP fest 'Playground Feature: Markdown READMEs 18' Oct 26, 2021
src/components/Markdown.tsx Outdated Show resolved Hide resolved
src/components/MdeEditor.tsx Outdated Show resolved Hide resolved
src/components/ProjectInfo.tsx Outdated Show resolved Hide resolved
src/components/ProjectInfo.tsx Show resolved Hide resolved
src/containers/Editor/components.tsx Outdated Show resolved Hide resolved
src/containers/Editor/components.tsx Outdated Show resolved Hide resolved
src/containers/Editor/components.tsx Outdated Show resolved Hide resolved
src/containers/Editor/components.tsx Outdated Show resolved Hide resolved
@hichana
Copy link
Contributor Author

hichana commented Nov 4, 2021

Thanks for the feedback @MaxStalker. I've made all the changes, and also added an eof space to Spinner.tsx, which also lacked one. Please let me know if anything else comes up with this submission.

@kerrywei kerrywei requested a review from MaxStalker November 4, 2021 16:48
Copy link
Contributor

@MaxStalker MaxStalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more small tweaks 😛

src/containers/Editor/components.tsx Outdated Show resolved Hide resolved
src/containers/Editor/components.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@MaxStalker MaxStalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

Copy link
Contributor

@MaxStalker MaxStalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 👍

@kerrywei kerrywei linked an issue Dec 16, 2021 that may be closed by this pull request
@sideninja
Copy link
Contributor

@alse @MrDSGC please take a look into this one

@alse alse changed the base branch from master to staging September 8, 2022 20:05
@sideninja sideninja closed this Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overview/Readme for Projects
4 participants