Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trace generation and GCP uploading functionality #6841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Dec 29, 2024

Closes #6840

Note: Removes also the following execution config flags:

  • --evm-tracing-enabled
  • --evm-traces-gcp-bucket

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.09%. Comparing base (219660a) to head (864797e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6841      +/-   ##
==========================================
- Coverage   41.12%   41.09%   -0.03%     
==========================================
  Files        2107     2105       -2     
  Lines      185330   185030     -300     
==========================================
- Hits        76220    76045     -175     
+ Misses     102710   102592     -118     
+ Partials     6400     6393       -7     
Flag Coverage Δ
unittests 41.09% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

I think its safest if we deploy this during an HCU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] Decommission the traces generation & GCP upload
3 participants