Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the EVM.dryCall method #6838

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Dec 27, 2024

Closes #6800

This new method can be used instead of COA.call, in a Cadence transaction, when the user wants to execute a contract call, without committing any state changes. This is useful for reading a contract's state.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 70.14925% with 20 lines in your changes missing coverage. Please review.

Project coverage is 41.13%. Comparing base (219660a) to head (bcfb56f).

Files with missing lines Patch % Lines
fvm/evm/impl/impl.go 69.49% 9 Missing and 9 partials ⚠️
utils/unittest/execution_state.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6838   +/-   ##
=======================================
  Coverage   41.12%   41.13%           
=======================================
  Files        2107     2107           
  Lines      185330   185395   +65     
=======================================
+ Hits        76220    76258   +38     
- Misses     102710   102727   +17     
- Partials     6400     6410   +10     
Flag Coverage Δ
unittests 41.13% <70.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This new method can be used instead of COA.call, in a Cadence transaction,
when the users wants to execute a contract call, without committing any
state changes. This is useful for reading a contract's state.
@m-Peter m-Peter force-pushed the mpeter/implement-evm-dry-call branch from efd6cc6 to 56eeb97 Compare December 29, 2024 12:05
@m-Peter m-Peter marked this pull request as ready for review December 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new API on EVM contract to support read-only calls on a transaction context
2 participants