-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Add implementation for transaction statuses data providers #6818
[Access] Add implementation for transaction statuses data providers #6818
Conversation
…The-K-R-O-K/flow-go into AndriiDiachuk/6586-tx-statuses-data-providers-impl
…' of github.com:The-K-R-O-K/flow-go into AndriiDiachuk/6586-tx-statuses-data-providers-impl
…github.com:The-K-R-O-K/flow-go into AndriiDiachuk/6586-tx-statuses-data-providers-impl
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6818 +/- ##
==========================================
+ Coverage 41.12% 41.19% +0.06%
==========================================
Files 2107 2109 +2
Lines 185335 185633 +298
==========================================
+ Hits 76228 76463 +235
- Misses 102706 102757 +51
- Partials 6401 6413 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
engine/access/rest/websockets/data_providers/send_transaction_statuses_provider.go
Outdated
Show resolved
Hide resolved
engine/access/rest/websockets/data_providers/send_transaction_statuses_provider_test.go
Outdated
Show resolved
Hide resolved
engine/access/rest/websockets/data_providers/send_transaction_statuses_provider.go
Outdated
Show resolved
Hide resolved
…github.com:The-K-R-O-K/flow-go into AndriiDiachuk/6586-tx-statuses-data-providers-impl
engine/access/rest/websockets/data_providers/transaction_statuses_provider_test.go
Outdated
Show resolved
Hide resolved
engine/access/rest/websockets/data_providers/events_provider_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes: #6586
In this PR
TransactionStatusesDataProvider
andSendTransactionStatusesDataProvider
was implemented.New functionality was covered with tests.