Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Add implementation for transaction statuses data providers #6818

Conversation

AndriiDiachuk
Copy link
Contributor

@AndriiDiachuk AndriiDiachuk commented Dec 17, 2024

Closes: #6586

In this PR TransactionStatusesDataProvider and SendTransactionStatusesDataProvider was implemented.

New functionality was covered with tests.

Guitarheroua and others added 23 commits November 19, 2024 13:42
…The-K-R-O-K/flow-go into AndriiDiachuk/6586-tx-statuses-data-providers-impl
…' of github.com:The-K-R-O-K/flow-go into AndriiDiachuk/6586-tx-statuses-data-providers-impl
…github.com:The-K-R-O-K/flow-go into AndriiDiachuk/6586-tx-statuses-data-providers-impl
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 66.06607% with 113 lines in your changes missing coverage. Please review.

Project coverage is 41.19%. Comparing base (0f4013e) to head (66a79b5).

Files with missing lines Patch % Lines
access/mock/api.go 0.00% 44 Missing ⚠️
.../access/rpc/backend/backend_stream_transactions.go 59.15% 24 Missing and 5 partials ⚠️
...ders/send_and_get_transaction_statuses_provider.go 80.30% 21 Missing and 5 partials ⚠️
...ts/data_providers/transaction_statuses_provider.go 89.85% 5 Missing and 2 partials ⚠️
cmd/util/cmd/run-script/cmd.go 0.00% 6 Missing ⚠️
access/handler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6818      +/-   ##
==========================================
+ Coverage   41.12%   41.19%   +0.06%     
==========================================
  Files        2107     2109       +2     
  Lines      185335   185633     +298     
==========================================
+ Hits        76228    76463     +235     
- Misses     102706   102757      +51     
- Partials     6401     6413      +12     
Flag Coverage Δ
unittests 41.19% <66.06%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…github.com:The-K-R-O-K/flow-go into AndriiDiachuk/6586-tx-statuses-data-providers-impl
access/api.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterargue peterargue added this pull request to the merge queue Jan 2, 2025
Merged via the queue into onflow:master with commit 72adf9e Jan 2, 2025
56 checks passed
@peterargue peterargue deleted the AndriiDiachuk/6586-tx-statuses-data-providers-impl branch January 2, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Add implementation for transaction status data providers
5 participants