Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Implement inactivity tracker #6817

Merged

Conversation

UlyanaAndrukhiv
Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv commented Dec 17, 2024

Closes: #6799

Context

This PR implements an inactivity tracker for the WebSocket controller. It ensures that WebSocket connections are closed if there are no active subscriptions for a configured period of time.

Guitarheroua and others added 19 commits December 4, 2024 13:10
…into UlianaAndrukhiv/6799-inactivity-tracker
…The-K-R-O-K/flow-go into krok/new-websockets
…into UlianaAndrukhiv/6799-inactivity-tracker
…into AndriiSlisarchuk/6640-responce-limit-tracker
…thub.com:The-K-R-O-K/flow-go into UlianaAndrukhiv/6799-inactivity-tracker
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 48.48485% with 17 lines in your changes missing coverage. Please review.

Project coverage is 41.24%. Comparing base (0f4013e) to head (1c4f2a7).

Files with missing lines Patch % Lines
cmd/access/node_builder/access_node_builder.go 0.00% 8 Missing ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 8 Missing ⚠️
engine/access/rest/websockets/controller.go 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6817      +/-   ##
==========================================
+ Coverage   41.12%   41.24%   +0.11%     
==========================================
  Files        2107     2078      -29     
  Lines      185335   183715    -1620     
==========================================
- Hits        76228    75770     -458     
+ Misses     102706   101600    -1106     
+ Partials     6401     6345      -56     
Flag Coverage Δ
unittests 41.24% <48.48%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue
Copy link
Contributor

@UlyanaAndrukhiv please address merge conflicts

@UlyanaAndrukhiv UlyanaAndrukhiv marked this pull request as ready for review December 30, 2024 11:26
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple small comments. I'm unsure if the test is actually verifying the connection is closed. otherwise, this looks good

engine/access/rest/websockets/config.go Outdated Show resolved Hide resolved
engine/access/rest/websockets/controller.go Outdated Show resolved Hide resolved
engine/access/rest/websockets/controller.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterargue peterargue added this pull request to the merge queue Jan 2, 2025
Merged via the queue into onflow:master with commit d71546c Jan 2, 2025
56 checks passed
@peterargue peterargue deleted the UlianaAndrukhiv/6799-inactivity-tracker branch January 2, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Implement inactivity tracker
6 participants