-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Implement inactivity tracker #6817
[Access] Implement inactivity tracker #6817
Conversation
…into krok/new-websockets
…into UlianaAndrukhiv/6799-inactivity-tracker
…The-K-R-O-K/flow-go into krok/new-websockets
…into UlianaAndrukhiv/6799-inactivity-tracker
…into AndriiSlisarchuk/6640-responce-limit-tracker
…krok/new-websockets
…krok/new-websockets
…krok/new-websockets
…krok/new-websockets
…thub.com:The-K-R-O-K/flow-go into UlianaAndrukhiv/6799-inactivity-tracker
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6817 +/- ##
==========================================
+ Coverage 41.12% 41.24% +0.11%
==========================================
Files 2107 2078 -29
Lines 185335 183715 -1620
==========================================
- Hits 76228 75770 -458
+ Misses 102706 101600 -1106
+ Partials 6401 6345 -56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…drukhiv/6799-inactivity-tracker
@UlyanaAndrukhiv please address merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a couple small comments. I'm unsure if the test is actually verifying the connection is closed. otherwise, this looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes: #6799
Context
This PR implements an
inactivity tracker
for theWebSocket
controller. It ensures thatWebSocket
connections are closed if there are no active subscriptions for a configured period of time.