[Access] Response limit tracker #6814
Open
+69
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6814 +/- ##
=======================================
Coverage 41.18% 41.18%
=======================================
Files 2109 2109
Lines 185660 185664 +4
=======================================
+ Hits 76460 76467 +7
+ Misses 102788 102784 -4
- Partials 6412 6413 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
illia-malachyn
changed the title
|
@Guitarheroua please address merge conflicts |
…isarchuk/6640-responce-limit-tracker
peterargue
approved these changes
Jan 1, 2025
| @@ -257,6 +261,11 @@ func (c *Controller) writeMessages(ctx context.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // wait for the rate limiter to allow the next message write. | |||
There was a problem hiding this comment.
I feel like this is a redundant comment. The code is pretty clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6640
NOTE: this PR should be merged after #6798
Implements rate limiter for responses, that controller returns to client.