-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Cadence v1.3.0 #6779
base: master
Are you sure you want to change the base?
Update to Cadence v1.3.0 #6779
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6779 +/- ##
==========================================
- Coverage 40.98% 40.75% -0.23%
==========================================
Files 2100 1966 -134
Lines 184862 171702 -13160
==========================================
- Hits 75769 69984 -5785
+ Misses 102723 95939 -6784
+ Partials 6370 5779 -591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Unrelated tests are failing:
Can you PTAL at 1. @durkmurder @jordanschalm @AlexHentschel, and 2. @peterargue 🙏 Could be caused by the version bump of the test assertion library, github.com/stretchr/testify from v1.9.0 to v1.10.0, specifically stretchr/testify#1661 / stretchr/testify#1664 |
NotSame checks pointer inequality; the input was not a pointer. This caused a failure once testify was updated to explicitly catch and throw an error in this case.
@turbolent Pushed 662fc0d to address (1). Thanks for linking the testify changes 🙇. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks @turbolent for updating to Cadence v1.3.0! 🎉
Description
Automatically update to:
Required for #6761