Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence v1.3.0 #6779

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Dec 3, 2024

Description

Automatically update to:

Required for #6761

@turbolent turbolent requested a review from Kay-Zee as a code owner December 3, 2024 23:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 35.44304% with 102 lines in your changes missing coverage. Please review.

Project coverage is 40.75%. Comparing base (088596f) to head (f8499f0).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cmd/util/ledger/migrations/cadence_value_diff.go 31.70% 54 Missing and 2 partials ⚠️
cmd/util/cmd/check-storage/cmd.go 0.00% 23 Missing ⚠️
...il/cmd/check-storage/evm_account_storage_health.go 52.17% 10 Missing and 1 partial ⚠️
cmd/util/cmd/generate-authorization-fixes/cmd.go 0.00% 3 Missing ⚠️
.../migrations/filter_unreferenced_slabs_migration.go 75.00% 2 Missing and 1 partial ⚠️
cmd/util/cmd/checkpoint-collect-stats/cmd.go 0.00% 2 Missing ⚠️
...md/util/ledger/reporters/fungible_token_tracker.go 80.00% 1 Missing and 1 partial ⚠️
cmd/util/cmd/diff-states/cmd.go 0.00% 1 Missing ⚠️
cmd/util/ledger/util/atree_util.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6779      +/-   ##
==========================================
- Coverage   40.98%   40.75%   -0.23%     
==========================================
  Files        2100     1966     -134     
  Lines      184862   171702   -13160     
==========================================
- Hits        75769    69984    -5785     
+ Misses     102723    95939    -6784     
+ Partials     6370     5779     -591     
Flag Coverage Δ
unittests 40.75% <35.44%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent
Copy link
Member Author

turbolent commented Dec 4, 2024

NotSame checks pointer inequality; the input was not a pointer. This
caused a failure once testify was updated to explicitly catch and throw
an error in this case.
@jordanschalm
Copy link
Member

@turbolent Pushed 662fc0d to address (1). Thanks for linking the testify changes 🙇.

Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @turbolent for updating to Cadence v1.3.0! 🎉

@turbolent turbolent enabled auto-merge December 18, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants