Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Implement subscribe transaction statuses by transaction ID #6737

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
ed80a0c
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua Dec 17, 2024
103d15d
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
peterargue Dec 17, 2024
4b7275b
Apply suggestions from code review
Guitarheroua Dec 20, 2024
5ede502
fixed remarks
Guitarheroua Dec 20, 2024
80b63eb
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua Dec 20, 2024
c1dc45a
Apply suggestions from code review
Guitarheroua Dec 27, 2024
0f1ad0d
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua Dec 27, 2024
e53c356
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
peterargue Dec 27, 2024
93c69c1
change to irrecoverable throw
Guitarheroua Dec 30, 2024
a162ba2
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
peterargue Jan 2, 2025
383b7e8
Implement remarks. Added txRefID for subscribe calls. Added test.
Guitarheroua Jan 8, 2025
7184c8e
Started to implement state detection on transaction suscription
Guitarheroua Jan 9, 2025
725ccda
Fixed issues with test failint
Guitarheroua Jan 13, 2025
25493da
Get rid of unnecessary api calls
Guitarheroua Jan 16, 2025
733a485
Merge branch 'master' of github.com:The-K-R-O-K/flow-go into AndriiSl…
Guitarheroua Jan 16, 2025
1170a55
Fixed crash
Guitarheroua Jan 16, 2025
b427e33
Fixed issue with statuses sending
Guitarheroua Jan 16, 2025
03c5be5
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua Jan 17, 2025
d1d0466
Added more uinit tests for subscribe tx statuses
Guitarheroua Jan 20, 2025
4aa5d14
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua Jan 20, 2025
52bc521
linted
Guitarheroua Jan 20, 2025
65a0757
extract tx_sub_metadata structure
Guitarheroua Jan 22, 2025
fd4afd1
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua Jan 22, 2025
b291085
fixed test
Guitarheroua Jan 22, 2025
a3f45e1
Merge branch 'AndriiSlisarchuk/6573-pending-should-return-immediately…
Guitarheroua Jan 22, 2025
fa5f03f
simplify logic
Guitarheroua Jan 22, 2025
a51b1fb
finished refactoring
Guitarheroua Jan 22, 2025
02e1d83
linted
Guitarheroua Jan 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions engine/access/rpc/backend/backend_stream_transactions.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,7 @@ func (b *backendSubscribeTransactions) SubscribeTransactionStatusesFromLatest(
) subscription.Subscription {
header, err := b.txLocalDataProvider.state.Sealed().Head()
if err != nil {
b.log.Error().Err(err).Msg("failed to retrieve latest block")
return subscription.NewFailedSubscription(err, "failed to retrieve latest block")
irrecoverable.Throw(ctx, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wrap this with some context so it's obvious why the node crashed

}

return b.createSubscription(ctx, txID, header.ID(), 0, flow.ZeroID, requiredEventEncodingVersion, false)
Expand Down
Loading