-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Implement subscribe transaction statuses by transaction ID #6737
Draft
Guitarheroua
wants to merge
28
commits into
onflow:master
Choose a base branch
from
The-K-R-O-K:AndriiSlisarchuk/6573-pending-should-return-immediately
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
ed80a0c
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua 103d15d
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
peterargue 4b7275b
Apply suggestions from code review
Guitarheroua 5ede502
fixed remarks
Guitarheroua 80b63eb
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua c1dc45a
Apply suggestions from code review
Guitarheroua 0f1ad0d
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua e53c356
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
peterargue 93c69c1
change to irrecoverable throw
Guitarheroua a162ba2
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
peterargue 383b7e8
Implement remarks. Added txRefID for subscribe calls. Added test.
Guitarheroua 7184c8e
Started to implement state detection on transaction suscription
Guitarheroua 725ccda
Fixed issues with test failint
Guitarheroua 25493da
Get rid of unnecessary api calls
Guitarheroua 733a485
Merge branch 'master' of github.com:The-K-R-O-K/flow-go into AndriiSl…
Guitarheroua 1170a55
Fixed crash
Guitarheroua b427e33
Fixed issue with statuses sending
Guitarheroua 03c5be5
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua d1d0466
Added more uinit tests for subscribe tx statuses
Guitarheroua 4aa5d14
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua 52bc521
linted
Guitarheroua 65a0757
extract tx_sub_metadata structure
Guitarheroua fd4afd1
Merge branch 'master' into AndriiSlisarchuk/6573-pending-should-retur…
Guitarheroua b291085
fixed test
Guitarheroua a3f45e1
Merge branch 'AndriiSlisarchuk/6573-pending-should-return-immediately…
Guitarheroua fa5f03f
simplify logic
Guitarheroua a51b1fb
finished refactoring
Guitarheroua 02e1d83
linted
Guitarheroua File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please wrap this with some context so it's obvious why the node crashed