-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emulator Feature: Report gas used #87
Emulator Feature: Report gas used #87
Conversation
Thank you for adding this, it looks good, however, it does highlight the lack of tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing tests needs to be implemented
Thanks for checking the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just added some minor comments about naming.
Co-authored-by: Janez Podhostnik <[email protected]>
I see, I also think that if it is more appropriate to use that term than Gas, it should be modified. |
Closes: FLIP Fest issue 12 onflow/flip-fest#12
Description
There should be a way to see transaction gas (computation) usage.
With this change, the output result of the transaction execution will look like this
BEFORE
AFTER
Other
Since there was no specific test code for the standard output of "txID=xxxxxx" that is currently displayed, I decided that there was no need to add any specific test code for this change as well.
I checked to see if any changes were needed in this document, but it looks like no changes are needed.
https://docs.onflow.org/flow-cli/start-emulator/
For contributor use:
master
branchFiles changed
in the Github PR explorer