REST API streaming support #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
==========================================
- Coverage 54.12% 51.83% -2.30%
==========================================
Files 29 30 +1
Lines 3706 3870 +164
==========================================
Hits 2006 2006
- Misses 1539 1702 +163
- Partials 161 162 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@peterargue can you have a look at this? I am not sure if we need execution streaming here or just events are enough |
bluesign
requested review from
sideninja,
turbolent,
janezpodhostnik and
chasefleming
as code owners
sideninja
reviewed
Nov 13, 2023
sideninja
reviewed
Nov 13, 2023
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/onflow/flow-go/crypto](https://github.com/onflow/flow-go) from 0.24.9 to 0.24.10. - [Release notes](https://github.com/onflow/flow-go/releases) - [Commits](onflow/flow-go@v0.24.9...v0.24.10) --- updated-dependencies: - dependency-name: github.com/onflow/flow-go/crypto dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/gorilla/mux](https://github.com/gorilla/mux) from 1.8.0 to 1.8.1. - [Release notes](https://github.com/gorilla/mux/releases) - [Commits](gorilla/mux@v1.8.0...v1.8.1) --- updated-dependencies: - dependency-name: github.com/gorilla/mux dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
sideninja
approved these changes
Nov 13, 2023
|
@bluesign good to merge? |
Should be good, just this ID I will investigate a bit later but we can merge |
yeah doesn't matter as much for now |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #495
Description
Currently trie updates are not implemented but as-is it is enough to provide events, currently REST API does not allow state streaming AFAIK, so I marked as ready for review. ( as it is a blocker for FCL work )
For contributor use:
masterbranchFiles changedin the GitHub PR explorer