Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate add with install in DM and allow multiple dependency installation #1841

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Nov 22, 2024

Closes #1755

Description

Consolidate add with install in Dependency Manager and allow for multiple dependency installs. e.g. can now do flow dependencies install FlowToken NonFungibleToken


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@chasefleming chasefleming added the Improvement Technical work without new features, refactoring, improving tests label Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 8.51064% with 43 lines in your changes missing coverage. Please review.

Project coverage is 27.90%. Comparing base (c73ef4e) to head (ffc5d9a).

Files with missing lines Patch % Lines
internal/dependencymanager/install.go 0.00% 40 Missing ⚠️
internal/dependencymanager/add.go 0.00% 2 Missing ⚠️
internal/dependencymanager/dependencyinstaller.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
- Coverage   28.47%   27.90%   -0.57%     
==========================================
  Files          95       95              
  Lines        6490     6482       -8     
==========================================
- Hits         1848     1809      -39     
- Misses       4462     4497      +35     
+ Partials      180      176       -4     
Flag Coverage Δ
unittests 27.90% <8.51%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chasefleming chasefleming merged commit 4bf9dc0 into master Nov 25, 2024
5 checks passed
@chasefleming chasefleming deleted the cf/1755 branch November 25, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine flow deps add & flow deps install commands
3 participants