Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alias adding in Dependency Manager if no dependency yet #1836

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Nov 19, 2024

Closes #1800

Description

Entering an alias was failing if the dependency didn't exist in flow.json yet. Changes the order of operations to add the dependency to the state before doing any additional tasks.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.47%. Comparing base (ba90dd8) to head (75c3674).

Files with missing lines Patch % Lines
internal/dependencymanager/dependencyinstaller.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   28.47%   28.47%           
=======================================
  Files          95       95           
  Lines        6490     6490           
=======================================
  Hits         1848     1848           
  Misses       4462     4462           
  Partials      180      180           
Flag Coverage Δ
unittests 28.47% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@chasefleming chasefleming added the Bug The issue represents a bug, malfunction, regression label Nov 19, 2024
@chasefleming chasefleming merged commit 659c356 into master Nov 19, 2024
7 checks passed
@chasefleming chasefleming deleted the cf/1800 branch November 19, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The issue represents a bug, malfunction, regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency Manager Testnet Address configuration not working properly
3 participants