Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1716
Description
When using a
flow.json
configuration file withdependencies
that point to Testnet, then the dependency manager currently implicitly fetches the service account contract8c5303eaa26202d6.FlowContractAudits
, which has not been updated to Cadence 1.0:This happens if a dependency directly or indirectly depends on a contract in the same account.
This is because currently, when the dependency manager is asked to fetch a dependency (and recursively its dependencies), the manager always fetches all contracts of the account and parses them all, even though only one dependency is requested.
Unless I'm missing something, there is no need to fetch and parse all account contracts, and it is actually incorrect to fail adding a dependency because an unrelated contract in the same account happens to be broken.
Simply fetch the account's contracts, and only parse the requested contract (if it exists).
For contributor use:
master
branchFiles changed
in the Github PR explorer