-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only save a project if its creation is entirely successful #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasefleming
requested review from
Kay-Zee,
janezpodhostnik,
sideninja,
nvdtf,
bluesign,
bjartek,
jribbink and
ianthpun
as code owners
May 1, 2024 19:28
chasefleming
added
Feature
A new user feature or a new package API
and removed
Feature
A new user feature or a new package API
labels
May 1, 2024
jribbink
reviewed
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just some nits about error handling mostly
Co-authored-by: Jordan Ribbink <[email protected]>
Co-authored-by: Jordan Ribbink <[email protected]>
Co-authored-by: Jordan Ribbink <[email protected]>
Co-authored-by: Jordan Ribbink <[email protected]>
Co-authored-by: Jordan Ribbink <[email protected]>
…into chasefleming/1531
ianthpun
approved these changes
May 1, 2024
jribbink
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1531
This creates the whole project in a system temporary directory until the entire project is successfully created, otherwise it is destroyed. Upon successful creation, it moves it out of the temp directory and into the target directory.
For contributor use:
master
branchFiles changed
in the Github PR explorer