Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only save a project if its creation is entirely successful #1553

Merged
merged 11 commits into from
May 1, 2024

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented May 1, 2024

Closes #1531

This creates the whole project in a system temporary directory until the entire project is successfully created, otherwise it is destroyed. Upon successful creation, it moves it out of the temp directory and into the target directory.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@chasefleming chasefleming added Feature A new user feature or a new package API and removed Feature A new user feature or a new package API labels May 1, 2024
Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just some nits about error handling mostly

internal/super/setup.go Outdated Show resolved Hide resolved
internal/super/setup.go Outdated Show resolved Hide resolved
internal/super/setup.go Outdated Show resolved Hide resolved
internal/super/setup.go Outdated Show resolved Hide resolved
internal/super/setup.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works.

If we can just cleanup printing the temp paths (maybe just exclude them, reference them as relative instead of absolute, or print the target paths instead) that would be awesome:

image

@chasefleming chasefleming merged commit d356ca2 into feature/interactive-init May 1, 2024
5 checks passed
@chasefleming chasefleming deleted the chasefleming/1531 branch May 1, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants