Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Flow Go v0.34.0-crescendo-preview.17 #1551

Closed
wants to merge 12 commits into from
Closed

Update to Flow Go v0.34.0-crescendo-preview.17 #1551

wants to merge 12 commits into from

Conversation

sideninja
Copy link
Contributor

Closes #???

Description

This PR update to latest preview Flow Go version v0.34.0-crescendo-preview.17

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

jribbink and others added 9 commits April 24, 2024 18:20
@jribbink
Patch for flags error message (#1539)
952a96b
@jribbink2
Update version.txt (#1540)
78d2894
@jribbink
Use Homebrew latest version instead of version.txt (#1545)
d63de49
@dependabot
Bump golangci/golangci-lint-action from 3.7.0 to 5.1.0
cfd712b 
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.7.0 to 5.1.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.7.0...v5.1.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@chasefleming
Merge pull request #1549 from onflow/dependabot/github_actions/golang…
83ef40f 
…ci/golangci-lint-action-5.1.0

Bump golangci/golangci-lint-action from 3.7.0 to 5.1.0
@sideninja
Merge branch 'master' into feature/stable-cadence
0f9049f 
# Conflicts:
#	internal/command/command.go
@sideninja
update emulator
042c3c9
@sideninja
update ci go version
195d001
@sideninja
fix changes in api
23ba504
@sideninja sideninja self-assigned this Apr 30, 2024
@sideninja sideninja changed the base branch from master to feature/stable-cadence April 30, 2024 22:17
jribbink
jribbink approved these changes Apr 30, 2024
View reviewed changes
internal/migrate/staging_validator.go Outdated Show resolved Hide resolved
@turbolent
Copy link
Member

Like I commented here onflow/flow-evm-gateway#218 (comment), this release is not going to have updated all the cadence tools (linter, test framework, etc), right?

turbolent
turbolent requested changes Apr 30, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All dependencies should be updated to the same version

@jribbink
Copy link
Contributor

jribbink commented Apr 30, 2024 •
edited
Loading

@turbolent

We will update cadence-tools/test, cadence-tools/lint, and cadence-tools/languageserver to the latest dependency versions. Just wanted to flag that flow-go isn't using the latest Cadence verison (it is on v1.0.0-preview.23 right now, not v1.0.0-preview.24), so these tools/the CLI will still be behind the latest Cadence changes slightly.

@turbolent
Copy link
Member

@jribbink Yeah, this is another problem. We want to get a release with Cadence v1.0.0-preview.24 out. I'm working on updating to that at the moment.

Let's sync on it tomorrow, see https://discord.com/channels/613813861610684416/1108479699732152503/1235021376570658846

@turbolent
Copy link
Member

Replaced by #1564, which updates to more recent versions of the dependencies.

Let's move the merge of master into feature/stable-cadence into a separate PR.

@turbolent turbolent closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent requested changes

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@nvdtf nvdtf nvdtf approved these changes

@jribbink jribbink jribbink approved these changes

@chasefleming chasefleming chasefleming approved these changes

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee

@bluesign bluesign Awaiting requested review from bluesign

@bjartek bjartek Awaiting requested review from bjartek

@ianthpun ianthpun Awaiting requested review from ianthpun

Assignees

@sideninja sideninja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sideninja @turbolent @jribbink @chasefleming @nvdtf @janezpodhostnik @jribbink2