Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stderr to output test runner logs #1461

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Use stderr to output test runner logs #1461

merged 2 commits into from
Mar 18, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Mar 18, 2024

Closes #1460

Description

Sends test logs to stderr. They are currently suppressed with latest versions of the CLI.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.07%. Comparing base (c0a70d6) to head (18023b4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1461      +/-   ##
==========================================
+ Coverage   41.05%   41.07%   +0.01%     
==========================================
  Files          51       51              
  Lines        2957     2958       +1     
==========================================
+ Hits         1214     1215       +1     
  Misses       1591     1591              
  Partials      152      152              
Flag Coverage Δ
unittests 41.07% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ianthpun ianthpun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as @chasefleming , feel free to merge once done. thanks!

@jribbink jribbink merged commit 5f6355c into master Mar 18, 2024
5 checks passed
@jribbink jribbink deleted the jribbink/test-logs branch March 18, 2024 22:38
jribbink added a commit that referenced this pull request Mar 18, 2024
* Update version.txt to v1.15.0

* Use stderr to output test runner logs (#1461)

---------

Co-authored-by: Chase Fleming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flow test logs are suppressed
4 participants