Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Cadence 1.0 pre-release installer #1410

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Feb 14, 2024

Closes #1374

Description

Creates a Cadence 1.0 pre-release installer. This installer will iterate through all of the Flow CLI releases (99.99999% will be on first page anyways) and install the latest release containing cadence-v1.0.0.

  • We should update C1.0 install instructions to run the install script from stable-cadence branch instead of master
  • We should make sure that all C1.0 releases are tagged with vX.X.X-cadence-v1.0.0.X
  • We should make sure that we do not merge these changes into master as they are C1-specific and temporary

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (752eb7b) 40.60% compared to head (b51a223) 40.60%.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/stable-cadence    #1410   +/-   ##
=======================================================
  Coverage                   40.60%   40.60%           
=======================================================
  Files                          47       47           
  Lines                        2596     2596           
=======================================================
  Hits                         1054     1054           
  Misses                       1417     1417           
  Partials                      125      125           
Flag Coverage Δ
unittests 40.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

install.ps1 Outdated Show resolved Hide resolved
install.ps1 Outdated Show resolved Hide resolved
@chasefleming
Copy link
Member

@jribbink what about uninstalling? Should we add support for that too?

@jribbink
Copy link
Contributor Author

@jribbink what about uninstalling? Should we add support for that too?

I think this is probably a separate ticket. It's not blocking to get this functionality out & we don't even provide a mechanism (outside of homebrew) to do this with our existing install script. It's probably a question of providing an uninstall.sh/uninstall.ps1 script IMO.

Copy link
Contributor

@ianthpun ianthpun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, lets give it a shot

@jribbink jribbink changed the base branch from master to feature/stable-cadence February 16, 2024 21:08
@jribbink jribbink force-pushed the jribbink/flow-c1-installer branch from 45c30fa to b51a223 Compare February 16, 2024 21:10
@jribbink jribbink merged commit 9ecc47d into feature/stable-cadence Feb 16, 2024
5 checks passed
@jribbink jribbink deleted the jribbink/flow-c1-installer branch February 16, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stable Cadence Installation Workflow
4 participants