Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch feature/stable-cadence branch to Cadence 1.0 FCL Dev Wallet #1356

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Switch feature/stable-cadence branch to Cadence 1.0 FCL Dev Wallet #1356

merged 3 commits into from
Feb 1, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Jan 24, 2024 •
edited
Loading

closes #1357

Updates the Dev Wallet to use the C1.0 tagged release instead on the stable-cadence Flow CLI branch.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added dependencies Pull requests that update a dependency file Cadence 1.0 labels Jan 24, 2024
@jribbink
Copy link
Contributor Author

Looks like CI is failing on the feature/stable-cadence branch

@jribbink jribbink changed the title Switch to C1.0 Dev Wallet Switch feature/stable-cadence branch to Cadence 1.0 FCL Dev Wallet Jan 24, 2024
@jribbink jribbink linked an issue Jan 25, 2024 that may be closed by this pull request
Update Dev Wallet to Cadence 1.0 #1357
Closed
@jribbink jribbink requested a review from ianthpun February 1, 2024 03:53
@chasefleming chasefleming merged commit b459d07 into feature/stable-cadence Feb 1, 2024
5 checks passed
@chasefleming chasefleming deleted the jribbink/c1-dev-wallet branch February 1, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

@bjartek bjartek bjartek approved these changes

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

@sideninja sideninja Awaiting requested review from sideninja

@nvdtf nvdtf Awaiting requested review from nvdtf

@bluesign bluesign Awaiting requested review from bluesign

@ianthpun ianthpun Awaiting requested review from ianthpun

Assignees
No one assigned
Labels
Cadence 1.0 dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Dev Wallet to Cadence 1.0
4 participants
@jribbink @bjartek @chasefleming @ianthpun