Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct import of deprecated flow-go/crypto #1349

Closed
wants to merge 7 commits into from

Conversation

tarakby
Copy link

@tarakby tarakby commented Jan 17, 2024

Remove direct import of deprecated flow-go/crypto. This is done by:

  • updating flow-go-sdk version to 0.44.0 (version that does not use flow-go/crypto anymore)
  • updating flow-go version after merging Revert deleted crypto/hash and crypto/random packages flow-go#5239 (not use flow-go/crypto)
  • update flow-emulator to branch tarak/v0.58.1-0-with-crypto-type-fixes/ to fix crypto type mismatches.
  • running go generate

Copy link
Collaborator

@bjartek bjartek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there plans to remove it from flow-go aswell?

@tarakby
Copy link
Author

tarakby commented Jan 25, 2024

It just got removed from flow-go. I am working on removing it from all the repos. This PR is not ready yet though, there is a messy dependency yarn to solve first

@jribbink
Copy link
Contributor

closing this as it is outdated

@jribbink jribbink closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants