Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move create-interactive, support flow-cli testnet link with flow account fund #1326

Merged
merged 11 commits into from
Jan 4, 2024

Conversation

ianthpun
Copy link
Contributor

@ianthpun ianthpun commented Jan 3, 2024

Closes #1213

Description

image

Also added the flow account fund [ACCOUNT] command, which generates this and pops a browser window:

image


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Sorry, something went wrong.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (630168e) 40.74% compared to head (e3d85e8) 40.24%.
Report is 2 commits behind head on master.

Files Patch % Lines
internal/accounts/fund.go 0.00% 15 Missing ⚠️
internal/accounts/create-interactive.go 0.00% 12 Missing ⚠️
internal/accounts/accounts.go 11.11% 7 Missing and 1 partial ⚠️
internal/accounts/create.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
- Coverage   40.74%   40.24%   -0.51%     
==========================================
  Files          39       40       +1     
  Lines        2118     2152      +34     
==========================================
+ Hits          863      866       +3     
- Misses       1160     1189      +29     
- Partials       95       97       +2     
Flag Coverage Δ
unittests 40.24% <7.31%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianthpun ianthpun marked this pull request as ready for review January 3, 2024 21:52
@chasefleming
Copy link
Member

On the issue there is the fund command. I think it might still be useful to have that command open up this pre populated url. Curious what others think.

@jribbink
Copy link
Contributor

jribbink commented Jan 4, 2024

On the issue there is the fund command. I think it might still be useful to have that command open up this pre populated url. Curious what others think.

Yeah I can see a few situations in which a dev wants to later fund an account so no harm in keeping that door open IMO. I think best structure is probably flow accounts fund MY_ACCT, that way we avoid bloating top-level commands as much as possible. It's probably a really easy task so we might as well just do it

internal/accounts/accounts.go Outdated Show resolved Hide resolved
ianthpun and others added 5 commits January 4, 2024 10:29

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Bastian Müller <[email protected]>
@ianthpun ianthpun changed the title move create-interactive, support flow-cli testnet link move create-interactive, support flow-cli testnet link with flow account fund Jan 4, 2024
@ianthpun
Copy link
Contributor Author

ianthpun commented Jan 4, 2024

@chasefleming @jribbink ive now added the flow accounts fund MY_ACCT functionality which would pop a browser window for you to complete the hcaptcha and get your account funded. It also has validation its only for testnet addresses. I'll make sure to update the docs on this next once this has been merged. THanks everyone!

@ianthpun ianthpun merged commit 63643d1 into master Jan 4, 2024
5 checks passed
@ianthpun ianthpun deleted the ianthpun/testnet-faucet branch January 4, 2024 20:11
@chasefleming chasefleming added the Feature A new user feature or a new package API label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a command for funding an account on testnet
6 participants