Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a contract to deployment section when using flowkit.AddContract #1247

Merged

Conversation

bjartek
Copy link
Collaborator

@bjartek bjartek commented Oct 25, 2023

Closes #1201

Description

When adding a Contract it is added to the contracts state but not to deployments if the deployment network does not exist already.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@bjartek bjartek changed the title test: failing test Adding a contract to deployment section when using flowkit.AddContract Oct 25, 2023
@bjartek bjartek marked this pull request as ready for review October 25, 2023 15:48
@bjartek
Copy link
Collaborator Author

bjartek commented Oct 25, 2023

Not quite sure why my editor (nvim) deletes these lines, if you want me to i can add them back once the logic is approved.

@bjartek bjartek added Bug The issue represents a bug, malfunction, regression go Pull requests that update Go code labels Oct 25, 2023
@chasefleming
Copy link
Member

@bjartek looks like tests are failing

@bjartek
Copy link
Collaborator Author

bjartek commented Oct 25, 2023

It fails because testnet is sporking

@bjartek
Copy link
Collaborator Author

bjartek commented Oct 26, 2023

@chasefleming tests should work now.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4edd362) 38.65% compared to head (bf00858) 40.79%.
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
+ Coverage   38.65%   40.79%   +2.14%     
==========================================
  Files          38       38              
  Lines        1948     1978      +30     
==========================================
+ Hits          753      807      +54     
+ Misses       1107     1082      -25     
- Partials       88       89       +1     
Flag Coverage Δ
unittests 40.79% <ø> (+2.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming chasefleming merged commit fef7105 into master Oct 26, 2023
6 checks passed
@chasefleming chasefleming deleted the bjartek/add-deployment-block-when-adding-contract branch October 26, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The issue represents a bug, malfunction, regression go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing deployments section stops script execution
4 participants