Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace contract body encoding from hex to utf8 #1220

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

nozim
Copy link
Contributor

@nozim nozim commented Sep 26, 2023

Closes #1195

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

Copy link
Member

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nozim looks like this breaks the tests

@nozim
Copy link
Contributor Author

nozim commented Sep 26, 2023

@chasefleming will have a look. Thanks

@nozim nozim requested a review from chasefleming September 27, 2023 12:50
@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Sep 27, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6dc3fec) 39.47% compared to head (f2f9fb9) 38.65%.
Report is 106 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   39.47%   38.65%   -0.83%     
==========================================
  Files          37       38       +1     
  Lines        1882     1948      +66     
==========================================
+ Hits          743      753      +10     
- Misses       1051     1107      +56     
  Partials       88       88              
Flag Coverage Δ
unittests 38.65% <ø> (-0.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming chasefleming merged commit 24caae4 into onflow:master Sep 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Use .utf8 instead of hex-encoding/decoding
4 participants