Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build and address cross compilation #1341

Closed
tarakby opened this issue Jan 12, 2024 · 1 comment
Closed

Fix broken build and address cross compilation #1341

tarakby opened this issue Jan 12, 2024 · 1 comment
Assignees
Labels
Bug The issue represents a bug, malfunction, regression

Comments

@tarakby
Copy link

tarakby commented Jan 12, 2024

Problem

Current release build on master is broken after importing the latest version of the crypto package. The new crypto package version requires CGO to be enabled and requires specifying the correct C compiler for cross-compilation (the new crypto version uses portable and non-portable code). The current CI build cross compiles on the same machine for multiple targets.
For now, a workaround is to use the old crypto version (which uses go build tags to not include the non-portable code part). This issue aims to solve the cross-compilation properly with a proper solution.

cc @sideninja

@tarakby tarakby added the Bug The issue represents a bug, malfunction, regression label Jan 12, 2024
@tarakby tarakby self-assigned this Jan 12, 2024
@tarakby tarakby moved this to 🔖 Ready for Pickup in 🌊 Flow 4D Jan 12, 2024
@chasefleming
Copy link
Member

This has been fixed by: #1423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The issue represents a bug, malfunction, regression
Projects
None yet
Development

No branches or pull requests

2 participants