Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Standard: Decentralized identifiers (DIDs) on Flow - Milestone 1 #97

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

mwufi
Copy link

@mwufi mwufi commented Oct 30, 2021

New Standard: Decentralized identifiers (DIDs) on Flow - Milestone 1

Description

This PR is for issue #17 (#17)

Submission Links & Documents

Flow DID Spec

Live Demo on netlify

  1. Create a collection
  2. Register a name
  3. Lookup a name
    Please open the Devtools while these are happening (haven't implemented appropriate UI yet)

Github repo

Requirements Check

  • Have have you met the milestone requirements? YES
  • Have you included tests (if applicable)? YES
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? YES
  • If this is the last milestone: NO

Other Details

  • Is there anything specific you'd like the PoC to know or review for? NO
  • Are there other references, documentation, or relevant artificats to mention for this PR (ie. external links to justify design decisions, etc.)? NO

@kerrywei kerrywei requested a review from gregsantos November 1, 2021 17:14
Copy link

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you submission @mwufi and team!
We have reviewed documentation and tested your demo app.
We are happy to approve this milestone as we were able to successfully register, resolve, update and add signatures via your did service!
The UI is clean and informative as well and we especially like the live search capability!
As your submission seems to qualify for additional milestones we will be expecting those soon!
Thank you again and nice work on this issue!

Copy link

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@srinjoyc srinjoyc merged commit 1ea4cc6 into onflow:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants