Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Wallet Feature: Improve OpenID implementation - Milestone 1 - Dev Wallet OIDC #87

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

wfalcon0x
Copy link
Contributor

Dev Wallet Feature: Improve OpenID implementation - Milestone 1

Description

This PR is for issue #10

This submission includes 2 options of UI wireframes for Manage account screens and one solution for the accept
Permissions screen.

Submission Links & Documents

Requirements Check

  • Have have you met the milestone requirements?
  • Have you included tests (if applicable)?
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)?
  • If this is the last milestone:
    • Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.)
    • Demonstrate that you've met all milestone requirements and highlight any extensions or additional work done.
    • Include a payout structure by percentage for each team member (ie. Bob: 20%, Alice: 80%).

Other Details

  • Is there anything specific you'd like the PoC to know or review for?
  • Are there other references, documentation, or relevant artificats to mention for this PR (ie. external links to justify design decisions, etc.)?

@kerrywei kerrywei requested a review from 10thfloor October 28, 2021 22:40
@10thfloor
Copy link
Contributor

Great! Thanks for this. I prefer version 2 of the wireframes.
Milestone 1 complete. Sorry for the delay in getting back to you.

@10thfloor 10thfloor merged commit 69ae51f into onflow:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants