Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground Feature: Improve the resource explorer 29 - Milestone 3 #75

Merged

Conversation

hichana
Copy link
Contributor

@hichana hichana commented Oct 22, 2021

Playground Feature: Improve the resource explorer 29 - Milestone 3

Description

This PR is for issue #29 - Playground Feature: Improve the resource explorer - Milestone 3.

I have added full support for a user-friendly integrated resources explorer functionality that maintains continuity of the user experience while allowing users to clearly explore account resources as they are updated by various transactions. While maintaining the aesthetic and user experience of the existing playground, as well as the codebase conventions and style, my solution allows users to achieve the following:

  • quick way to inspect multiple accounts
  • provide visual cues for items in storage
  • message to the user which accounts have had their storage updated and which accounts processed the transaction to make that update
  • autogenerate basic script or transaction templates by clicking on a stored item in the resources explorer

Submission Links & Documents

  • I made a comprehensive guide with notes and instructions on how to run the updated UI locally HERE.
  • the PR for the milestone is HERE.

Requirements Check

  • Have have you met the milestone requirements? Yes
  • Have you included tests (if applicable)? N/A
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? Yes
  • If this is the last milestone:
    • Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.).: Please see a comprehensive guide I made HERE.
    • Demonstrate that you've met all milestone requirements and highlight any extensions or additional work done.: Please see a comprehensive guide I made HERE.
    • Include a payout structure by percentage for each team member (ie. Bob: 20%, Alice: 80%).: @hichana: 100%

@sideninja sideninja requested a review from MaxStalker October 22, 2021 11:10
@hichana hichana changed the title Submissions/issue #29/milestone 3/hichana Playground Feature: Improve the resource explorer 29 - Milestone 3 Oct 24, 2021
@kerrywei
Copy link

kerrywei commented Nov 5, 2021

update: Max communicated with @hichana in Discord channel on this.

@hichana
Copy link
Contributor Author

hichana commented Nov 5, 2021

Hi @kerrywei \o/

Anything I can do for this one?

@kerrywei
Copy link

kerrywei commented Nov 5, 2021

@hichana I believe my teammate and you discussed this PR in Discord? If that's not the case, cc @MaxStalker to clarify here

@MaxStalker
Copy link
Contributor

🎉 Milestone Achieved 🎉

@kerrywei
Copy link

kerrywei commented Nov 6, 2021

@hichana do you want to resolve the conflict so that we can merge in this PR?

@kerrywei
Copy link

kerrywei commented Nov 6, 2021

if you can un-check in these .DS_Store files, the conflicts should be resolved

@hichana
Copy link
Contributor Author

hichana commented Nov 7, 2021

@MaxStalker @kerrywei I've removed the .DS_Store file, thank you.

Copy link

@kerrywei kerrywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge in the PR per Max's comment

@kerrywei kerrywei merged commit f0ca83b into onflow:main Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants