Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create milestone-1.md #73

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Create milestone-1.md #73

merged 1 commit into from
Oct 26, 2021

Conversation

NguyenIvan
Copy link
Contributor

PR Title

Please format your PR title as follows:

[Issue Name] - Milestone [Milestone #]

Example: CLI Feature: State management - Milestone 1

Description

This PR is for issue (insert issue number here).

Example: This PR is for issue #22

  • Provide a summary of the work completed in this PR.
  • List of requirements that are being submitted.

Submission Links & Documents

  • Include all links to PRs on other repositories (if required) and be clear as to what it does. Ensure you follow the PR guidelines on the other repositories.
    • Include or highlight any new updates made from a previous submission or milestone.

Requirements Check

  • Have have you met the milestone requirements?
  • Have you included tests (if applicable)?
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)?
  • If this is the last milestone:
    • Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.)
    • Demonstrate that you've met all milestone requirements and highlight any extensions or additional work done.
    • Include a payout structure by percentage for each team member (ie. Bob: 20%, Alice: 80%).

Other Details

  • Is there anything specific you'd like the PoC to know or review for?
  • Are there other references, documentation, or relevant artificats to mention for this PR (ie. external links to justify design decisions, etc.)?

@bebner
Copy link

bebner commented Oct 21, 2021

This is referring to this pull request on the Crypto-Dappy Github repositroy

@sideninja
Copy link
Contributor

This is referring to this pull request on the Crypto-Dappy Github repositroy

So this is not really a CLI feature for state management?

@NguyenIvan
Copy link
Contributor Author

@sideninja it is not about CLI feature. It is about decentralized trading based on NFTStorefront contract. The first milestone is about UI. Correct me if I missed anything?

@NguyenIvan
Copy link
Contributor Author

By the way I am done with NFTStorefront unit testing. Ready to complete Milestone 2

@bebner
Copy link

bebner commented Oct 22, 2021

Hey @NguyenIvan, just reviewed your solution of milestone number 1, and it fulfils all requirements and can be considered as passed!

@NguyenIvan
Copy link
Contributor Author

Thank you very much @bebner. I am heading toward to the next milestone submission.

@srinjoyc srinjoyc merged commit 755378c into onflow:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants