Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Feature: Test suite - Milestone 1 #49

Conversation

jrkhan
Copy link

@jrkhan jrkhan commented Sep 29, 2021

CLI Feature: Test suite - Milestone 1

Description

This PR is for issue #13.

  • Establishing pattern for unit testing for command layer of flow CLI

Submission Links & Documents

Requirements Check

  • Have have you met the milestone requirements? Not yet
  • Have you included tests (if applicable)? In progress
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? Yes

Other Details

  • After discussion in issue thread, wanted to confirm this approach is on the right track

@psiemens psiemens requested a review from sideninja October 3, 2021 14:13
Copy link
Contributor

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the PR

@kerrywei
Copy link

closing this PR -- Gregor and the author are continuing the conversation in PR jrkhan-bot/flow-cli#4
Thank you for participating in FLIP FEST @jrkhan 👍

@kerrywei kerrywei closed this Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants