Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Tool: Events indexing service - Milestone 2 #106

Merged
merged 1 commit into from
Nov 4, 2021
Merged

New Tool: Events indexing service - Milestone 2 #106

merged 1 commit into from
Nov 4, 2021

Conversation

chriswayoub
Copy link
Contributor

This PR is for issue #15

Submission Links & Documents

MVP for indexing service:

https://github.com/chriswayoub/flow-scanner

@kerrywei kerrywei requested a review from nvdtf November 1, 2021 17:34
nvdtf
nvdtf approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@nvdtf nvdtf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project seems past MVP phase. I think the current code satisfies MVP requirements.

@kerrywei
Copy link

kerrywei commented Nov 4, 2021

merge in this PR per Navid's comment

@kerrywei kerrywei merged commit 760cc07 into onflow:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdtf nvdtf nvdtf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriswayoub @kerrywei @nvdtf