Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tool: Events indexing service - Milestone 1 #105

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

chriswayoub
Copy link
Contributor

This PR is for issue #15

Submission Links & Documents

Design Document:

https://grey-volleyball-300.notion.site/Flow-Scanner-Architecture-c26277e1ff464b8394f0c9520ffd6c25

Code will be hosted here (if you are not already added then shoot me a message to request access):

Indexing Service

Example Deployment

@kerrywei kerrywei requested a review from nvdtf November 1, 2021 17:34
Copy link
Member

@nvdtf nvdtf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!

I had the impression that each box on the design document is a separate service, but looking at the codebase it seems like the design has evolved a bit. I think what we have here can serve as a good starting design document. I'll dive deeper into the code in the subsequent PRs.

@kerrywei
Copy link

kerrywei commented Nov 4, 2021

merge in this PR per Navid's comment

@kerrywei kerrywei merged commit 620cd77 into onflow:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants