Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKG -- [transport-http] Create SubscriptionManager and subscribe function #2019

Merged
merged 8 commits into from
Nov 26, 2024
Merged

PKG -- [transport-http] Create SubscriptionManager and subscribe function #2019

merged 8 commits into from
Nov 26, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Nov 20, 2024 •
edited
Loading

Closes #2015

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0773a8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jribbink jribbink force-pushed the jribbink/subscription-manager branch from 8c8c7af to 7119077 Compare November 25, 2024 23:35
@jribbink jribbink changed the title Jribbink/subscription manager PKG -- [transport-http] Create SubscriptionManager and subscribe function Nov 25, 2024
@jribbink jribbink marked this pull request as ready for review November 25, 2024 23:38
@jribbink jribbink requested a review from a team as a code owner November 25, 2024 23:38
@jribbink jribbink changed the base branch from master to feature/streaming November 25, 2024 23:40
@jribbink jribbink mentioned this pull request Nov 25, 2024
Merged
@jribbink jribbink changed the base branch from feature/streaming to master November 25, 2024 23:42
@jribbink jribbink changed the base branch from master to feature/streaming November 25, 2024 23:42
jribbink
jribbink commented Nov 26, 2024
View reviewed changes
packages/typedefs/src/index.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking to see if there's an easy way to move these types to the SDK and make the SDK a peer dependency of transport-http.

I think that realistically this is where the types belong, so if I can set this up somehow without having circular dependency issues, that would be best.

@jribbink jribbink merged commit 7081ebf into feature/streaming Nov 26, 2024
1 check passed
@jribbink jribbink deleted the jribbink/subscription-manager branch November 26, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Streaming] Create transport-http SubscriptionManager
2 participants
@jribbink @chasefleming