PKG -- [fcl] Default to localStorage #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1782-jribbink/localstorage
🦋 Changeset detectedLatest commit: 427fb46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jribbink
changed the title
chasefleming
approved these changes
Nov 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2002
This PR includes the following:
fcl.storage.defaultkey and passes this as an initialization parameter instead (I feel that the former is an anti-pattern)FCL's actor model creates global singletons in the
window.FCL_REGISTRYobject. As config is an actor, this means thatfcl.storage.defaultis globally shared in the DOM. Because extension wallets (e.g. Flow Wallet) load FCL within a content script, it means that the default storage is overwritten (regresses to sessionStorage, in spite of changing default in FCL).In an ideal world, FCL would not have such side effects. This is the motivation for moving the storage to an initialization parameter instead. It helps bring things one step closer to eliminating some of this global state in FCL.