PKG -- [sdk] TS voucher #1803
Merged
PKG -- [sdk] TS voucher #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch to uuid from @onflow/utils-uid * create tsconfigs * typedefs in ts * types for actor util * types for address util * Revert "switch to uuid from @onflow/utils-uid" This reverts commit 2a15ef5. * PKG -- [util-actor] converted to ts * updated tsconfig * fixed ts types generation * Resolve circular dependency * ts rlp * change type location * more types * build types during regular build * fix tests * VSN -- [root] Changeset * Merge remote-tracking branch 'origin/master' into nialexsan/add-types * Revert "Resolve circular dependency" This reverts commit 36efc7d. * update lock * VSN -- [root] changeset
Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address
* [WIP] Convert @onflow/types to TS * stash * kind of working * fix package.json * fix dictionary * fix tests * stash * strong type tests * remove any * rename * changeset
* PKG -- [util-actor] Enhance TS support * rename handlerfnmap
* PKG -- [types] Simplify generics * Fix array * Fix Array
* PKG -- [config] Add TypeScript * Changeset * fixup * Remove unnecessary generic from util-actor * remove non null assertions --------- Co-authored-by: Alex <[email protected]>
nialexsan
changed the title
…sion-fixed-merge-conflicts
…lexsan/ts-conversion-voucher-recolve-merge-conflict
…lexsan/ts-conversion-voucher-recolve-merge-conflict
…sion-fixed-merge-conflicts
Base automatically changed from
nialexsan/ts-conversion-fixed-merge-conflicts
to
master
November 27, 2023 21:33
…rge-conflicts' into nialexsan/ts-conversion-voucher-recolve-merge-conflict
…sion-voucher-recolve-merge-conflict
jribbink
requested changes
Nov 28, 2023
jribbink
reviewed
Nov 28, 2023
|
|
||
| export function sansPrefix(address: null): null; | ||
| export function sansPrefix(address: string): string; | ||
| export function sansPrefix(address: string | null): string | null; |
There was a problem hiding this comment.
There was a problem hiding this comment.
without this overload ts fails to compile
nialexsan
changed the title
nialexsan
deleted the
nialexsan/ts-conversion-voucher-recolve-merge-conflict
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.